Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JNI wrapper for the cuFile API (GDS) [skip ci] #6940

Merged
merged 16 commits into from
Dec 10, 2020
Merged

Add JNI wrapper for the cuFile API (GDS) [skip ci] #6940

merged 16 commits into from
Dec 10, 2020

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Dec 8, 2020

This adds a libcufilejni.so that's by default not built nor loaded. The unit tests are controlled similarly.

Tested locally with the corresponding spark-rapids plugin changes.

@jlowe @revans2 @abellina

@rongou rongou requested a review from a team as a code owner December 8, 2020 09:56
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@rongou rongou added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Java) Reviewer Java Affects Java cuDF API. doc Documentation non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS labels Dec 8, 2020
@rongou rongou mentioned this pull request Dec 8, 2020
Merged
revans2
revans2 reviewed Dec 8, 2020
View reviewed changes
Copy link
Contributor

@revans2 revans2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

java/pom.xml Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/CuFile.java Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/CuFile.java Outdated Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/CuFile.java Outdated Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/CuFile.java Outdated Show resolved Hide resolved
java/src/main/native/src/CuFileJni.cpp Outdated Show resolved Hide resolved
revans2
revans2 reviewed Dec 9, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@rongou rongou changed the title [REVIEW] Add JNI wrapper for the cuFile API (GDS) [skip ci] Add JNI wrapper for the cuFile API (GDS) [skip ci] Dec 10, 2020
@rapids-bot rapids-bot bot merged commit 89938fa into rapidsai:branch-0.18 Dec 10, 2020
@rongou rongou mentioned this pull request Jan 5, 2021
Closed
11 tasks
@rongou rongou deleted the cufile-jni branch November 23, 2021 17:26
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond doc Documentation Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rongou @GPUtester @revans2 @vyasr