Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds in JNI support for creating an list column from existing columns [skip ci] #7112

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Adds in JNI support for creating an list column from existing columns [skip ci] #7112

merged 2 commits into from
Jan 11, 2021

Conversation

revans2
Copy link
Contributor

@revans2 revans2 commented Jan 11, 2021

Adds in java support to be able to create a list column from other existing columns.

@revans2 revans2 added 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 11, 2021
@revans2 revans2 self-assigned this Jan 11, 2021
@revans2 revans2 requested a review from a team as a code owner January 11, 2021 17:48
@revans2 revans2 mentioned this pull request Jan 11, 2021
Merged
jlowe
jlowe reviewed Jan 11, 2021
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a copyright update on a file but otherwise lgtm.

java/src/main/native/src/ColumnVectorJni.cpp Show resolved Hide resolved
@jlowe jlowe added 5 - Ready to Merge Testing and reviews complete, ready to merge 6 - Okay to Auto-Merge and removed 4 - Needs cuDF (Java) Reviewer labels Jan 11, 2021
@rapids-bot rapids-bot bot merged commit 11ebc3e into rapidsai:branch-0.18 Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees

@revans2 revans2

Labels
3 - Ready for Review Ready for review by team 5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@revans2 @jlowe