Java bindings for Fixed-point type support for Parquet #7153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razajafri
added
3 - Ready for Review
razajafri
changed the title
|
build |
|
I have removed the [skip ci] as this change has some very small CPP header file change |
jlowe
requested changes
Jan 15, 2021
| @@ -846,6 +846,18 @@ class chunked_parquet_writer_options_builder { | |||
| return *this; | |||
There was a problem hiding this comment.
This is the only file cpp-codeowners need to approve. I will approve once the copyright is changed to 2020-2021
| @@ -18,6 +18,10 @@ | |||
|
|
|||
revans2
reviewed
Jan 15, 2021
|
build |
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #7153 +/- ##
===============================================
+ Coverage 82.09% 82.17% +0.07%
===============================================
Files 97 97
Lines 16474 16541 +67
===============================================
+ Hits 13524 13592 +68
+ Misses 2950 2949 -1
Continue to review full report at Codecov.
|
|
build |
karthikeyann
approved these changes
Jan 20, 2021
jlowe
requested changes
Jan 20, 2021
jlowe
approved these changes
Jan 20, 2021
razajafri
added
5 - Ready to Merge
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in java support to be able to write fixed-point type to parquet