Fix scatter output size for structs. #8155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Output struct size must match target column, not source. 2. Test case for rapidsai#1. 3. Also, move scatter_struct_tests and scatter_list_tests from .cu to .cpp, for faster compile.
github-actions
bot
added
CMake
mythrocks
added
3 - Ready for Review
ttnghia
approved these changes
May 4, 2021
davidwendt
approved these changes
May 4, 2021
|
I'd better let @harrism off the hook on this one. Thanks for the reviews, @ttnghia && @davidwendt. |
mythrocks
added
5 - Ready to Merge
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #8155 +/- ##
===============================================
+ Coverage 82.88% 82.92% +0.03%
===============================================
Files 103 104 +1
Lines 17668 17896 +228
===============================================
+ Hits 14645 14840 +195
- Misses 3023 3056 +33
Continue to review full report at Codecov.
|
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8150, which causes CUDF failures if the
scatter()source struct column has a different size from that of the target. It turns out that the implementation was erroneously using the source column's size to construct the result, instead of the target's.The following changes were made in this commit:
scatter_lists_testandscatter_struct_testwere moved from.cuto.cpp, for faster compile.