Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concatenate empty structs #8947

Merged
merged 8 commits into from
Aug 6, 2021
Merged

Fix concatenate empty structs #8947

merged 8 commits into from
Aug 6, 2021

Conversation

sperlingxx
Copy link
Contributor

@sperlingxx sperlingxx commented Aug 4, 2021 •
edited
Loading

Closes #8929

Current PR is to fix the illegal memory access problem occurred when concatenating structs with empty children.

@sperlingxx
fix concat struct columns with empty children
fa7b8c4 
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
@sperlingxx sperlingxx requested a review from a team as a code owner August 4, 2021 04:05
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 4, 2021
@sperlingxx sperlingxx added 4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working non-breaking Non-breaking change and removed libcudf Affects libcudf (C++/CUDA) code. labels Aug 4, 2021
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 4, 2021
ttnghia
ttnghia requested changes Aug 4, 2021
View reviewed changes
cpp/src/structs/copying/concatenate.cu Outdated Show resolved Hide resolved
@ttnghia
Copy link
Contributor

ttnghia commented Aug 4, 2021 •
edited
Loading

In cudf PR, you don't have to add "Signed-off-by" in the PR description. Instead, add more true "description" for what the PR is doing. Also note that a description saying "Closes #....", or "Fixes #....." is not enough.

@sperlingxx @ttnghia
Update cpp/src/structs/copying/concatenate.cu
418fd9f 
Co-authored-by: Nghia Truong <ttnghia@users.noreply.github.com>
@sperlingxx sperlingxx requested a review from ttnghia August 5, 2021 10:41
@ttnghia
Copy link
Contributor

ttnghia commented Aug 5, 2021

Rerun tests.

ttnghia
ttnghia requested changes Aug 5, 2021
View reviewed changes
cpp/src/structs/copying/concatenate.cu Outdated Show resolved Hide resolved
@sperlingxx @ttnghia
Update cpp/src/structs/copying/concatenate.cu
e11c30f 
Co-authored-by: Nghia Truong <ttnghia@users.noreply.github.com>
@sperlingxx @ttnghia
Apply suggestions from code review
67332e0 
Co-authored-by: Nghia Truong <ttnghia@users.noreply.github.com>
@sperlingxx
Copy link
Contributor Author

@ttnghia Thanks for correcting my mistakes ^ ^

@codecov
Copy link

codecov bot commented Aug 6, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@fdf47af). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 7f6fca7 differs from pull request most recent head 59015ba. Consider uploading reports for the commit 59015ba to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #8947   +/-   ##
===============================================
  Coverage                ?   10.59%           
===============================================
  Files                   ?      116           
  Lines                   ?    19037           
  Branches                ?        0           
===============================================
  Hits                    ?     2017           
  Misses                  ?    17020           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdf47af...59015ba. Read the comment docs.

@sperlingxx
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ffb37c9 into rapidsai:branch-21.10 Aug 6, 2021
@sperlingxx sperlingxx deleted the fix_concat_struct_col_with_empty_child branch August 6, 2021 06:40
shwina pushed a commit to shwina/cudf that referenced this pull request Aug 9, 2021
@sperlingxx @shwina
Fix concatenate empty structs (rapidsai#8947)
012caf8 
Closes rapidsai#8929

Current PR is to fix the illegal memory access problem occurred when concatenating structs with empty children.

Authors:
  - Alfred Xu (https://github.com/sperlingxx)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Mike Wilson (https://github.com/hyperbolic2346)

URL: rapidsai#8947
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec

Assignees
No one assigned
Labels
4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] concat empty struct causes seg fault
3 participants
@sperlingxx @ttnghia @hyperbolic2346