Fix call to thrust::reduce_by_key in argmin/argmax libcudf groupby #9244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
jrhemstad
reviewed
Sep 20, 2021
jrhemstad
approved these changes
Sep 20, 2021
github-actions
bot
added
CMake
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #9244 +/- ##
================================================
- Coverage 10.85% 10.84% -0.01%
================================================
Files 115 116 +1
Lines 19158 19171 +13
================================================
Hits 2080 2080
- Misses 17078 17091 +13
Continue to review full report at Codecov.
|
robertmaynard
requested changes
Sep 21, 2021
…t/cudf into bug-sorted-groupby-min-strings
|
I seemed to have hosed my branch now. I will close the PR and reopen based on 21.10 |
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 22, 2021
…9263) Closes #9156 This PR simplifies the parameters when calling thrust::reduce_by_key for the argmin/argmax aggregations in cudf::groupby. The illegalMemoryAccess found in #9156 was due to invalid data being passed from thrust::reduce_by_key through to the BinaryPredicate function as documented in NVIDIA/thrust#1525 The invalid data being passed is only a real issue for strings columns where the device pointer was neither nullptr nor a valid address. The new logic provides only size_type values to thrust::reduce_by_key so invalid values can only be out-of-bounds for the input column which is easily checked before retrieving the string_view objects within the ArgMin and ArgMax operators. This the same as #9244 but based on 21.10 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Devavret Makkar (https://github.com/devavret) - Nghia Truong (https://github.com/ttnghia) - Robert Maynard (https://github.com/robertmaynard) URL: #9263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9156
This PR simplifies the parameters when calling
thrust::reduce_by_keyfor the argmin/argmax aggregations in cudf::groupby. TheillegalMemoryAccessfound in #9156 was due to invalid data being passed fromthrust::reduce_by_keythrough to the BinaryPredicate function as documented in NVIDIA/cccl#789The invalid data being passed is only a real issue for strings columns where the device pointer was neither nullptr nor a valid address. The new logic provides only
size_typevalues tothrust::reduce_by_keyso invalid values can only be out-of-bounds for the input column which is easily checked before retrieving thestring_viewobjects within the ArgMin and ArgMax operators.