Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex non-multiline EOL/$ matching strings ending with a new-line #9715

Merged
merged 3 commits into from
Nov 19, 2021

Conversation

davidwendt
Copy link
Contributor

Closes #9620

Fixes an edge case described in https://docs.python.org/3/library/re.html#re.MULTILINE
where the '$' EOL regex pattern character (without MULTILINE set) should match at the very end of a string and also just before the end of the string if the end of that string contains a new-line.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) non-breaking Non-breaking change labels Nov 17, 2021
@davidwendt davidwendt requested a review from a team as a code owner November 17, 2021 14:22
@davidwendt davidwendt self-assigned this Nov 17, 2021
@davidwendt davidwendt requested a review from a team as a code owner November 17, 2021 14:22
@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 17, 2021
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@7e4a985). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #9715   +/-   ##
===============================================
  Coverage                ?   10.60%           
===============================================
  Files                   ?      118           
  Lines                   ?    20082           
  Branches                ?        0           
===============================================
  Hits                    ?     2130           
  Misses                  ?    17952           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4a985...3013f3d. Read the comment docs.

@vuule vuule added 4 - Needs cuDF (Python) Reviewer and removed 3 - Ready for Review Ready for review by team labels Nov 18, 2021
@vuule
Copy link
Contributor

vuule commented Nov 19, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c1bfb26 into rapidsai:branch-22.02 Nov 19, 2021
@davidwendt davidwendt deleted the bug-eol-newline-wec branch November 19, 2021 13:42
@vyasr vyasr added the 4 - Needs Review Waiting for reviewer to review or respond label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API. strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Regex: $ does not match \n at end of string
5 participants