JNI: Function to copy and set validity from bool column. #9901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythrocks
added
feature request
jlowe
reviewed
Dec 14, 2021
1. Renamed to `copyWithBooleanColumnAsValidity()`. 2. Better documentation on null handling in validity column, failure conditions, etc. 3. Removed redundant error checks.
jlowe
reviewed
Dec 15, 2021
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9901 +/- ##
================================================
- Coverage 10.49% 10.40% -0.09%
================================================
Files 119 119
Lines 20305 20503 +198
================================================
+ Hits 2130 2134 +4
- Misses 18175 18369 +194
Continue to review full report at Codecov.
|
jlowe
approved these changes
Dec 15, 2021
|
@gpucibot merge |
|
Merged. Closing this PR out now. Thanks for the review, @jlowe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a JNI function
ColumnVector#copyWithValidity(ColumnView boolean_column)to use aBOOL8column as the validity buffer of a column.As per the convention in the JNI layer, this method does not modify the current object. A new
ColumnVectoris returned, containing the contents of the current object. The validity of the returnedColumnVectoris set to theDeviceBufferrepresentation of the logical contents of the suppliedBOOL8column.This method will be useful to set a column's validity based on a column resulting from a boolean operation.