Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable FutureWarnings and DeprecationWarnings as errors in cugraph #4415

Merged

Conversation

mroeschke
Copy link
Contributor

Supersedes #4271

There are some tests and internal usages of APIs that emit these warnings still. I don't know the best way to handle these warnings, but this PR ensures that new FutureWarnings and DeprecationWarnings will raise an error in the CI

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We may be able to remove some of the features that have exceeded the deprecation grace period and make this list smaller in a future PR.

@nv-rliu nv-rliu added improvement Improvement / enhancement to an existing function breaking Breaking change labels May 16, 2024
@mroeschke
Copy link
Contributor Author

Sorry for the delay. Finally got the CI to green

@nv-rliu
Copy link
Contributor

nv-rliu commented May 20, 2024

Sorry for the delay. Finally got the CI to green

I'm currently investigating the cudf warning when concatenating empty dfs, but should we go ahead and merge this issue? @rapidsai/cugraph-python-codeowners

@alexbarghi-nv
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 30c5edb into rapidsai:branch-24.06 May 20, 2024
135 checks passed
@mroeschke mroeschke deleted the test/futuredeprwarnings/errors branch May 20, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants