Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cmake infrastructure for internal projection library #1132

Merged
merged 36 commits into from
Jun 24, 2023
Merged

Add cmake infrastructure for internal projection library #1132

merged 36 commits into from
Jun 24, 2023

Conversation

harrism
Copy link
Member

@harrism harrism commented May 10, 2023 •
edited
Loading

Description

Adds cmake files, directory structure and placeholder source files. Closes #1127

Will not merge until I have some content ready for the library (e.g. a first API) in a followup PR.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added cmake Related to CMake code or build configuration conda Related to conda and conda configuration libcuspatial Relates to the cuSpatial C++ library labels May 10, 2023
@harrism harrism added feature request New feature or request non-breaking Non-breaking change and removed conda Related to conda and conda configuration cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels May 10, 2023
@harrism harrism self-assigned this May 10, 2023
@harrism harrism marked this pull request as ready for review May 10, 2023 04:11
@harrism harrism requested review from a team as code owners May 10, 2023 04:11
@harrism harrism requested review from isVoid and trxcllnt May 10, 2023 04:11
@github-actions github-actions bot added cmake Related to CMake code or build configuration conda Related to conda and conda configuration libcuspatial Relates to the cuSpatial C++ library labels May 10, 2023
isVoid
isVoid reviewed May 11, 2023
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not having enough cmake knowledge to give comprehensive review. Just some questions below.

cpp/CMakeLists.txt Show resolved Hide resolved
cuproj/cpp/cmake/thirdparty/CUPROJ_GetCUDF.cmake Outdated Show resolved Hide resolved
robertmaynard
robertmaynard requested changes May 12, 2023
View reviewed changes
cuproj/cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cuproj/cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@harrism harrism added the 5 - DO NOT MERGE Hold off on merging; see PR for details label May 13, 2023
@github-actions github-actions bot added ci Python Related to Python code labels May 31, 2023
trxcllnt
trxcllnt reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@trxcllnt trxcllnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions

@harrism harrism mentioned this pull request Jun 8, 2023
Merged
6 tasks
@harrism
Copy link
Member Author

harrism commented Jun 13, 2023

PROJ ARM64 conda package will be fixed in next release. OSGeo/PROJ#3746

Decision is for now to allow our CI to build PROJ from source on ARM64. @trxcllnt @robertmaynard can you please re-review / approve?

robertmaynard
robertmaynard requested changes Jun 14, 2023
View reviewed changes
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/cuproj/CMakeLists.txt Show resolved Hide resolved
harrism and others added 2 commits June 15, 2023 09:48
@harrism @robertmaynard
Update cpp/CMakeLists.txt
d063ca9 
Co-authored-by: Robert Maynard <robertjmaynard@gmail.com>
@harrism
Update CUPROJ VERSION in update-version.sh
fcdb4bb
@github-actions github-actions bot added the ci label Jun 14, 2023
robertmaynard
robertmaynard approved these changes Jun 21, 2023
View reviewed changes
cpp/cuproj/CMakeLists.txt Outdated Show resolved Hide resolved
@harrism
Copy link
Member Author

harrism commented Jun 24, 2023

/merge

@rapids-bot rapids-bot bot merged commit b047c6a into rapidsai:branch-23.08 Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

@isVoid isVoid isVoid left review comments

@trxcllnt trxcllnt trxcllnt approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees

@harrism harrism

Labels
3 - Ready for Review Ready for review by team ci cmake Related to CMake code or build configuration conda Related to conda and conda configuration feature request New feature or request libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake Infrastructure for new projections library
5 participants
@harrism @trxcllnt @robertmaynard @ajschmidt8 @isVoid