Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change path to trajectories_extracted.p to improve CI run consistency. #1247

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Change path to trajectories_extracted.p to improve CI run consistency. #1247

merged 3 commits into from
Aug 10, 2023

Conversation

thomcom
Copy link
Contributor

@thomcom thomcom commented Aug 2, 2023 •
edited
Loading

Description

Changes the URL to trajectories_extracted.p to a data.rapids.ai url, which should improve CI run stability for notebooks. @taureandyernv

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@thomcom thomcom self-assigned this Aug 2, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the Python Related to Python code label Aug 2, 2023
@thomcom thomcom requested review from harrism and isVoid August 2, 2023 20:52
@thomcom thomcom added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 2, 2023
@harrism
Copy link
Member

harrism commented Aug 3, 2023

Please target 23.10. Too late for 23.08

@thomcom thomcom changed the base branch from branch-23.08 to branch-23.10 August 7, 2023 16:51
@thomcom thomcom requested review from a team as code owners August 7, 2023 16:51
@isVoid
Copy link
Contributor

isVoid commented Aug 10, 2023

/merge

@rapids-bot rapids-bot bot merged commit 4220ab1 into rapidsai:branch-23.10 Aug 10, 2023
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid approved these changes

@harrism harrism Awaiting requested review from harrism

Assignees

@thomcom thomcom

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomcom @harrism @isVoid