Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark GeoSeries.Distance #1277

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Benchmark GeoSeries.Distance #1277

merged 1 commit into from
Oct 5, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Oct 5, 2023

Description

closes #994
There are primitive benchmark results for GeoSeries.distance in #1231. This PR plans to add more benchmark coverage:
TODO:

  • point-point
  • point-linestring
  • point-polygon
  • linestring-linestring
  • linestring-polygon
  • polygon-polygon
  • Geometry complexity dimension
  • Geometry spatial relationship dimension
  • Write the blog

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested a review from a team as a code owner October 5, 2023 01:23
@isVoid isVoid requested review from thomcom and harrism October 5, 2023 01:23
@github-actions github-actions bot added the Python Related to Python code label Oct 5, 2023
@isVoid isVoid mentioned this pull request Oct 5, 2023
Closed
12 tasks
@isVoid isVoid added improvement Improvement / enhancement to an existing function 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Oct 5, 2023
harrism
harrism approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @isVoid

@bdice
Copy link
Contributor

bdice commented Oct 5, 2023

/merge

@rapids-bot rapids-bot bot merged commit 366183c into rapidsai:branch-23.10 Oct 5, 2023
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@thomcom thomcom Awaiting requested review from thomcom thomcom is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Benchmark ST_Distance
3 participants
@isVoid @bdice @harrism