New build process script changes & gpuCI enhancements #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raydouglass
added
feature request
dillon-cullinan
approved these changes
Jan 12, 2021
| if (( ${EXITCODE} != 0 )); then | ||
| SUITEERROR=${EXITCODE} | ||
| echo "FAILED: GTest ${gt}" | ||
| fi |
There was a problem hiding this comment.
Looks like a messed up indentation here.
ajschmidt8
approved these changes
Jan 13, 2021
raydouglass
added
6 - Okay to Auto-Merge
and removed
3 - Ready for Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes and supersedes #314
New build process script changes
This PR outlines the changes necessary for the new build process (aka Project Flash) to work with
cuspatial. This PR is necessary to begin shadow testing of the new build process.The goal is to simultaneously support both the old and new build processes. CI is configured to activate the new process by setting
PROJECT_FLASH=1. AdditionallyBUILD_LIBCUSPATIALandBUILD_CUSPATIALwill be set to 1 as needed by CI in the new process.CI will stage build artifacts for python and GPU builds in
ci/artifacts/cuspatial/cpu/which the build scripts will then consume.The Project Flash script branch has been manually tested. This PR will test the non-Project Flash branch.
gpuCI enhancements