[REVIEW] Pin gdal to 3.1.x #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
okay to test |
harrism
added
conda
ajschmidt8
requested changes
Jan 14, 2021
|
Please update the GDAL version here (https://github.com/rapidsai/cuspatial/blob/branch-0.18/ci/gpu/build.sh#L46-L48) to confirm everything works as expected |
|
ok to test |
|
Great, thanks everyone for pointing me to all the different places! Do we need to merge rapidsai/integration#204 before this PR? And now that all the tests pass, can I revert the |
Yup, merged the integration PR. Revert the |
This reverts commit a49e0ab.
kkraus14
approved these changes
Jan 15, 2021
ajschmidt8
approved these changes
Jan 15, 2021
kkraus14
added
5 - Ready to Merge
ajschmidt8
pushed a commit
that referenced
this pull request
Mar 5, 2021
Bump `gdal` from 3.1.x to 3.2.x. Supersedes #339. This is inline with conda-forge's current migration to gdal=3.2.x (see conda-forge/conda-forge-pinning-feedstock#922 and https://conda-forge.org/status/#gdal32). Update on rapidsai/integration is at rapidsai/integration#211. Authors: - Wei Ji (@weiji14) Approvers: - AJ Schmidt (@ajschmidt8) - Keith Kraus (@kkraus14) URL: #347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump
gdalfrom 3.0.x to 3.1.x, fixes #327 and supersedes/reverts #245.