Add a static library for cuvs #382
Conversation
For the cuml integration, we need to be able to statically link to cuvs in order build the python wheels. This change adds a static target that lets us do that
benfred
added
improvement
cpp/CMakeLists.txt
Outdated
| target_link_libraries( | ||
| cuvs_static | ||
| PUBLIC rmm::rmm raft::raft ${CUVS_CTK_MATH_DEPENDENCIES} | ||
| PRIVATE nvidia::cutlass::cutlass $<TARGET_NAME_IF_EXISTS:OpenMP::OpenMP_CXX> |
There was a problem hiding this comment.
Shouldn't this target also link cuvs-cagra-search?
(just for recap: recently I added cuvs-cagra-search static target that holds only internally-used symbols for a subset of files, so that I could set specific CMake target flags only for these symbols)
There was a problem hiding this comment.
yeah - I agree this should link cuvs-cagra-search (and tried in the previous commit) . The error I was hitting was :
CMake Error in CMakeLists.txt:
export called with target "cuvs_static" which requires target
"cuvs-cagra-search" that is not in any export set.
https://github.com/rapidsai/cuvs/actions/runs/11155746120/job/31007185860
Will try your suggestion - thanks for this!
There was a problem hiding this comment.
works great - thanks! applied in latest commit
There was a problem hiding this comment.
Do you think we still need the cuvs-cagra-search in the install export set? Theoretically, we shouldn't be exposing that as a library and nobody outside cuVS should need to link against it. I suspect the error you saw previously was indirectly caused by the linker error and thus failure of CMake to register cuvs-cagra-search.
|
/merge |
For the cuml integration, we need to be able to statically link to cuvs in order build the python wheels. This change adds a static target that lets us do that