Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compiler variables #929

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

ajschmidt8
Copy link
Member

With the PR below merged, we no longer set the CXX, CC, or CUDAHOSTCXX variables in any of our CI images. This PR cleans up some references to them.

@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 7, 2022
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner June 7, 2022 15:56
@github-actions github-actions bot added the conda conda issue label Jun 7, 2022
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ajschmidt8

@codecov-commenter
Copy link

Codecov Report

Merging #929 (aa211e1) into branch-22.08 (e2ff3d7) will not change coverage.
The diff coverage is n/a.

❗ Current head aa211e1 differs from pull request most recent head 78a1ac5. Consider uploading reports for the commit 78a1ac5 to get more accurate results

@@              Coverage Diff              @@
##           branch-22.08    #929    +/-   ##
=============================================
  Coverage          0.00%   0.00%            
=============================================
  Files                22      16     -6     
  Lines              3075    2094   -981     
=============================================
+ Misses             3075    2094   -981     
Impacted Files Coverage Δ
dask_cuda/_version.py
dask_cuda/benchmarks/local_cudf_shuffle.py
dask_cuda/benchmarks/local_cupy_map_overlap.py
dask_cuda/benchmarks/utils.py
dask_cuda/benchmarks/local_cupy.py
dask_cuda/benchmarks/local_cudf_merge.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2ff3d7...78a1ac5. Read the comment docs.

@ajschmidt8
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f93a023 into rapidsai:branch-22.08 Jun 7, 2022
@ajschmidt8 ajschmidt8 deleted the rm-compiler-vars branch June 7, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants