Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scripts and actions for creating Windows containers for Windows 10 and 11. #87

Merged
merged 56 commits into from
Aug 25, 2023
Merged

Add scripts and actions for creating Windows containers for Windows 10 and 11. #87

merged 56 commits into from
Aug 25, 2023

Conversation

wmaxey
Copy link
Contributor

@wmaxey wmaxey commented Jul 5, 2023 •
edited
Loading

This makes 2 images for each compiler and CUDA entry in the matrix of:

2017, 2019, and 2022.
CUDA 11.1 and 12.1.

See packages here for results:
https://github.com/wmaxey?tab=packages&repo_name=cuda-windows-images

@rapids-bot
Copy link

rapids-bot bot commented Jul 5, 2023

Pull requests from external contributors require approval from a rapidsai organization member with write permissions or greater before CI can begin.

wmaxey
wmaxey commented Jul 5, 2023
View reviewed changes
.github/workflows/trigger_windows.yml Outdated
matrix:
runner: [windows-2019, windows-2022]
cuda_version: ["12.1", "11.1"]
edition: [windows-2019, windows-2022]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runner/edition can be different in the future. We'll likely refactor this before a new edition of GHA runners comes out.

@jrhemstad jrhemstad linked an issue Jul 5, 2023 that may be closed by this pull request
Create and publish Windows docker container images NVIDIA/cccl#82
Closed
trxcllnt
trxcllnt approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@trxcllnt trxcllnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should this be integrated into the main release job, or is it fine if we manually trigger releases separately?

@wmaxey
Copy link
Contributor Author

wmaxey commented Jul 10, 2023

LGTM. Should this be integrated into the main release job, or is it fine if we manually trigger releases separately?

I think manually is fine, or at the least your choice. Pushing the tags to dockerhub wasn't included in these changes.

@trxcllnt
Copy link
Collaborator

Ok, we'll probably want to do that.

@jrhemstad
Copy link
Collaborator

@miscco

@jrhemstad jrhemstad mentioned this pull request Jul 19, 2023
Closed
@miscco
Copy link
Collaborator

miscco commented Jul 21, 2023

@trxcllnt I have made some minor modifications to the PR. With those I was able to locally build the images and run our CI scripts inside the container.

@wmaxey wmaxey force-pushed the feature/add_windows_containers branch 4 times, most recently from a85bc14 to d1ef844 Compare July 28, 2023 01:47
@wmaxey
Copy link
Contributor Author

wmaxey commented Jul 28, 2023

@trxcllnt I have made some minor modifications to the PR. With those I was able to locally build the images and run our CI scripts inside the container.

I unfortunately rebased and force pushed over everything. I've updated to 12.2 and fixed the PR thing so it actually runs jobs.

@wmaxey
Copy link
Contributor Author

wmaxey commented Jul 28, 2023

Can publish images now only when desired by launching manually.

@wmaxey wmaxey force-pushed the feature/add_windows_containers branch 2 times, most recently from 580b6bc to f58ae54 Compare July 28, 2023 23:43
@trxcllnt trxcllnt changed the base branch from branch-23.08 to branch-23.10 August 1, 2023 22:17
@trxcllnt
fix build-and-test windows matrix
c4ba050
@trxcllnt
restrict windows matrix
3015c93
@trxcllnt
ignore changes to matrix.yaml
a0ec914
@trxcllnt
fix build-and-test-image.yml matrix
72d3cdd
@trxcllnt
ignore changes to .github files for now
0844e5a
@trxcllnt
get the actual version from the features
beee1cf
@trxcllnt
only consider files related to linux images
9f9c686
@trxcllnt
build one compiler version per job
9f98836
@trxcllnt
set the tag
55c5401
@trxcllnt
rename build-image build-linux-image
a35a200
@trxcllnt
split build-and-test into separate linux and windows jobs, test wcow …
fb78b40 
…image
@trxcllnt
split into separate build-and-test workflows
77b0139
@trxcllnt
split matrix + jobs into linux and windows at the top level
c99a4c6
@trxcllnt
fix image-matrix outputs
7e0b1e4
@trxcllnt
remove hyphen
64a19bb
@trxcllnt
rename build-and-push-image.yml -> build-and-push-linux-image.yml
0d209f5
@trxcllnt
add build-and-push-windows-image.yml, clean up unused actions and wor…
a21d156 
…kflows
@trxcllnt
consolidate build, test, and push workflows into one
a1e8194
@trxcllnt
fix names
d4727c0
@trxcllnt
remove dead code
f112c97
@trxcllnt
move scripts/windows -> windows
19e563c
@trxcllnt
reenable changed-files checks
7deaa4e
@trxcllnt
enable the full windows conatiner matrix
5ba19da
@trxcllnt
omit CUDA 11.1 + MSVC 2022 combinations
675e7d6
@trxcllnt
remove -x during build
9eebf71
@trxcllnt
include windows images when full_matrix=1
1f7f356
@trxcllnt
cache sccache output so what's printed is what's tested
25dccb3
@trxcllnt
Copy link
Collaborator

/ok to test

@trxcllnt trxcllnt merged commit 7adc52a into rapidsai:branch-23.10 Aug 25, 2023
243 checks passed
@wmaxey wmaxey deleted the feature/add_windows_containers branch September 18, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trxcllnt trxcllnt trxcllnt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create and publish Windows docker container images
4 participants
@wmaxey @trxcllnt @jrhemstad @miscco