-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
23.06 Install Page Update #396
23.06 Install Page Update #396
Conversation
@bdice Quick question on the bolded part below for this line since I think you're the person to ask (apologies if not!):
If they follow the steps from the link, is this accurate? We link to the guide to do a local install of a specific WSL Ubuntu 11.8 CTK that does not include the drivers. The guide says to end with the command Relevant since I'll need to add the CUDA 12 link and just want to make sure it's correct. FWIW when I installed it on my WSL2 machine a couple months ago I followed the guide exactly without issue. |
@jarmak-nv I want to be sure that users don't get tripped up by the second link. It says: Note the last line, |
I'm not sure how to move that forward -- but I think the download page should never advise installing a driver into a WSL system. If you know where to ask, please inquire about that and feel free to tag me! |
Don't the previous steps in the instructions make it install the version they downloaded though? the Per NV docs
I could easily be missing something though! |
@jarmak-nv Thanks for pointing that out. I don't think I was aware of that difference until now. Maybe I'm concerned about something that has already been solved? I know that users (and my former self) have run into situations where drivers were installed in WSL but maybe it's a case where they (and I) haven't read the directions carefully enough. |
Just to close the loop on this, I nuked one of my WSL Ubuntu 22.04 installs and started fresh following the page instructions and then doing a pip install of cuDF. Our suggested test command of
So I'll remove the note when I add CUDA 12 on Monday because I think it could lead to extra confusion and it's not needed. |
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I proposed some changes. I'll approve to unblock this PR. Please resolve my suggestions as you see fit.
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
I like the changes - technical writing like this always takes two sets of eyes at a minimum so thank you! |
This turned out smaller than expected, probably could have been part of #394 but I like smaller PRs anyway.
Python 3.8
support in pip installation guideContributes to #386