Leverage libcudacxx limits and cstdint defines #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bdice
approved these changes
May 22, 2023
|
@robertmaynard Are we planning to upstream these changes, too? |
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Yes there are plans to upstream this. Currently working on if these changes need to be conditional based on the CUDA version ( support < cuda 11 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using hardcoded defines in jitify generated content, leverage the defines that exist in libcudacxx
This removes compilation errors when the defines between jitify and libcudacxx differ ( e.g.
LLONG_MAX 0x7fffffffffffffffvsLLONG_MAX 0x7fffffffffffffffLL).Plus it removes the upkeep burden of jitify of having to stay in sync with header changes