Improve coalesced reduction performance for tall and thin matrices (up to 2.6x faster) #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lower LSU utilization and coalesced global stores
Nyrio
added
3 - Ready for Review
improvement
|
/ok to test |
|
/ok to test |
|
/ok to test |
tfeher
reviewed
Apr 12, 2024
tfeher
approved these changes
Apr 16, 2024
|
/ok to test |
|
/ok to test |
cjnolet
approved these changes
Apr 22, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements two optimizations to
coalescedReductionThinKernelwhich is used for coalesced reductions of tall matrices (many rows) and/or thin (few columns):The benchmark below shows the achieved SOL percentage on A30. I also measured that on H200, it achieved 84% SOL for 32 columns and up to 94% for 512 columns.