Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace too long index file name with hash in ANN bench #2280

Merged
merged 6 commits into from
May 21, 2024

Conversation

tfeher
Copy link
Contributor

@tfeher tfeher commented Apr 25, 2024

Too long index file name would lead to a crash while calling the index serialization routines. Such long filenames can occur if we try to specialize many parameters for CAGRA ann index. This PR fixes the issue by replacing the long index file name with a hash. Drawback is the filename will not be descriptive.

@tfeher tfeher requested a review from a team as a code owner April 25, 2024 21:38
@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels Apr 25, 2024
@cjnolet
Copy link
Member

cjnolet commented May 21, 2024

/merge

@rapids-bot rapids-bot bot merged commit a539c32 into rapidsai:branch-24.06 May 21, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change python
Projects
Development

Successfully merging this pull request may close these issues.

2 participants