Check generated JSON into source control #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
approved these changes
Jun 13, 2024
jameslamb
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Looks good! Thanks for adding --pretty... I think one day in the future, we'll be looking at the git blame on this rapids-metadata.json and be glad that we pretty-printed it from the beginning so we can see which parts changed and when at a glance.
I left a few small suggestions, do what you want with them. I don't need to review again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow projects to download the generated JSON directly from GitHub.