Skip to content

Commit

Permalink
Remove deprecated supports_streams and get_mem_info methods. (#1519)
Browse files Browse the repository at this point in the history
Fixes #1388 
Fixes #1389 
Fixes #1428
Fixes #1434

Removes the previously deprecated functions

 - `rmm::mr::device_memory_resource::supports_streams()`
 - `rmm::mr::device_memory_resource::supports_get_mem_info()`
 - `rmm::mr::device_memory_resource::get_mem_info()`

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Michael Schellenberger Costa (https://github.com/miscco)
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #1519
  • Loading branch information
harrism authored Apr 5, 2024
1 parent 8675b2c commit 48820cb
Showing 1 changed file with 0 additions and 46 deletions.
46 changes: 0 additions & 46 deletions include/rmm/mr/device/device_memory_resource.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -293,52 +293,6 @@ class device_memory_resource {
return !do_is_equal(other);
}

/**
* @brief Query whether the resource supports use of non-null CUDA streams for
* allocation/deallocation.
*
* @deprecated Functionality removed in favor of cuda::mr::async_memory_resource.
*
* @returns bool true if the resource supports non-null CUDA streams.
*/
[[deprecated("Functionality removed in favor of cuda::mr::async_memory_resource.")]] //
[[nodiscard]] virtual bool
supports_streams() const noexcept
{
return false;
}

/**
* @brief Query whether the resource supports the get_mem_info API.
*
* @deprecated Use rmm::available_device_memory instead.
*
* @return bool true if the resource supports get_mem_info, false otherwise.
*/
[[deprecated("Use rmm::available_device_memory instead.")]] //
[[nodiscard]] virtual bool
supports_get_mem_info() const noexcept
{
return false;
};

/**
* @brief Queries the amount of free and total memory for the resource.
*
* @deprecated Use rmm::available_device_memory instead.
*
* @param stream the stream whose memory manager we want to retrieve
*
* @returns a pair containing the free memory in bytes in .first and total amount of memory in
* .second
*/
[[deprecated("Use rmm::available_device_memory instead.")]] //
[[nodiscard]] std::pair<std::size_t, std::size_t>
get_mem_info(cuda_stream_view stream) const
{
return {0, 0};
}

/**
* @brief Enables the `cuda::mr::device_accessible` property
*
Expand Down

0 comments on commit 48820cb

Please sign in to comment.