Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to fmt 10.1.1 and spdlog 1.12.0. #117

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Update to fmt 10.1.1 and spdlog 1.12.0. #117

merged 6 commits into from
Nov 30, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 3, 2023 •
edited
Loading

This PR updates to fmt 10.1.1 and spdlog 1.12.

Depends on rapidsai/cudf#14355.

@bdice bdice added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Nov 3, 2023
@bdice bdice mentioned this pull request Nov 3, 2023
Merged
7 tasks
@bdice bdice changed the base branch from branch-0.35 to branch-0.36 November 20, 2023 22:03
@bdice bdice changed the title Build with fmt 10.1.1 and spdlog 1.12.0. Update to fmt 10.1.1 and spdlog 1.12.0. Nov 30, 2023
@bdice
Copy link
Contributor Author

bdice commented Nov 30, 2023

Revert changes that use CI artifacts and the upstream rapids-cmake branch before merging.

@bdice bdice marked this pull request as ready for review November 30, 2023 16:14
@bdice bdice requested review from a team as code owners November 30, 2023 16:14
wence-
wence- approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I think.

@raydouglass raydouglass merged commit fdce7b9 into rapidsai:branch-0.36 Nov 30, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@vyasr vyasr vyasr approved these changes

@AyodeAwe AyodeAwe AyodeAwe approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bdice @wence- @vyasr @AyodeAwe @raydouglass