-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Python ucxx code into python/ucxx #252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming there's nothing missing (i.e., CI passes), LGTM. Thanks @KyleFromNVIDIA .
This will probably require a devcontainers change: https://github.com/rapidsai/devcontainers/blob/541895260fa9d3d772989c55c64a3ab98323f1c4/features/src/rapids-build-utils/opt/rapids-build-utils/manifest.yaml#L42 cc @trxcllnt |
I've opened rapidsai/devcontainers#372 for this |
/merge |
Required for rapidsai/ucxx#252 Contributes to rapidsai/build-planning#33 --------- Co-authored-by: Paul Taylor <178183+trxcllnt@users.noreply.github.com>
Also fix up the isort configuration to get more correct results.
Contributes to rapidsai/build-planning#33