Skip to content

Commit

Permalink
fix: ensure field not null before checking constructor (#201)
Browse files Browse the repository at this point in the history
  • Loading branch information
alewitt2 authored Feb 24, 2021
1 parent e54a547 commit 58ced61
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/BaseController.js
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,7 @@ module.exports = class BaseController {
const configPathValue = objectPath.get(config, path);
// if config does not have the lastApplied path, make sure to set lastApplied path in config to null.
// we must avoid nulling any "objects", and only nulling "leafs", as we could delete other fields unintentionally.
if (configPathValue === undefined && lastApplied[key].constructor !== Object) {
if (configPathValue === undefined && lastApplied[key] && lastApplied[key].constructor !== Object) {
objectPath.set(config, path, null);
// elseif lastApplied[key] is not null/undefined, and it is an object, and configPathValue is not already set null by user, then we should recurse
} else if ((lastApplied[key] && lastApplied[key].constructor === Object && configPathValue !== null)) {
Expand Down

0 comments on commit 58ced61

Please sign in to comment.