Update: return error if key doesnt exist in secret (#147)

razee-io · Sep 8, 2020 · 703f006 · 703f006
1 parent 6d7b17d
commit 703f006
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/lib/BaseController.js b/lib/BaseController.js
@@ -228,7 +228,11 @@ module.exports = class BaseController {
 
   async getSecretData(name, key, ns, returnAsBuffer = false) {
     let res = await this.kubeResourceMeta.request({ uri: `/api/v1/namespaces/${ns || this.namespace}/secrets/${name}`, json: true });
-    let secret = Buffer.from(objectPath.get(res, ['data', key], ''), 'base64');
+    let base64KeyData = objectPath.get(res, ['data', key]);
+    if (base64KeyData === undefined) {
+      return Promise.reject(`key '${key}' in secret '${name}' from namespace '${ns}' not found`);
+    }
+    let secret = Buffer.from(base64KeyData, 'base64');
     return returnAsBuffer ? secret : secret.toString();
   }
   // ===========================================