Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure field not null before checking constructor #201

Merged
merged 1 commit into from
Feb 24, 2021
Merged

fix: ensure field not null before checking constructor #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/BaseController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,7 @@ module.exports = class BaseController {
const configPathValue = objectPath.get(config, path);
// if config does not have the lastApplied path, make sure to set lastApplied path in config to null.
// we must avoid nulling any "objects", and only nulling "leafs", as we could delete other fields unintentionally.
if (configPathValue === undefined && lastApplied[key].constructor !== Object) {
if (configPathValue === undefined && lastApplied[key] && lastApplied[key].constructor !== Object) {
objectPath.set(config, path, null);
// elseif lastApplied[key] is not null/undefined, and it is an object, and configPathValue is not already set null by user, then we should recurse
} else if ((lastApplied[key] && lastApplied[key].constructor === Object && configPathValue !== null)) {
Expand Down