-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fetchenv): allow label selectors on key lookups #293
Merged
alewitt2
merged 2 commits into
razee-io:master
from
answerbook:esatterwhite/env-label-selectors
Feb 18, 2022
Merged
feat(fetchenv): allow label selectors on key lookups #293
alewitt2
merged 2 commits into
razee-io:master
from
answerbook:esatterwhite/env-label-selectors
Feb 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accompanying pull request for the template controller |
esatterwhite
force-pushed
the
esatterwhite/env-label-selectors
branch
2 times, most recently
from
February 7, 2022 20:45
11379ea
to
c6726a5
Compare
esatterwhite
commented
Feb 7, 2022
esatterwhite
commented
Feb 7, 2022
esatterwhite
commented
Feb 7, 2022
esatterwhite
commented
Feb 7, 2022
esatterwhite
force-pushed
the
esatterwhite/env-label-selectors
branch
2 times, most recently
from
February 7, 2022 20:57
f1eed1d
to
f366bec
Compare
esatterwhite
commented
Feb 7, 2022
esatterwhite
force-pushed
the
esatterwhite/env-label-selectors
branch
from
February 8, 2022 15:57
f366bec
to
c9c70e8
Compare
alewitt2
reviewed
Feb 8, 2022
esatterwhite
commented
Feb 8, 2022
esatterwhite
force-pushed
the
esatterwhite/env-label-selectors
branch
from
February 8, 2022 18:20
c9c70e8
to
d48e1f0
Compare
alewitt2
reviewed
Feb 8, 2022
esatterwhite
force-pushed
the
esatterwhite/env-label-selectors
branch
from
February 8, 2022 23:34
d48e1f0
to
4b55c57
Compare
alewitt2
reviewed
Feb 9, 2022
esatterwhite
force-pushed
the
esatterwhite/env-label-selectors
branch
2 times, most recently
from
February 11, 2022 17:59
27be244
to
a72f5c9
Compare
esatterwhite
force-pushed
the
esatterwhite/env-label-selectors
branch
from
February 11, 2022 18:02
a72f5c9
to
834e486
Compare
alewitt2
reviewed
Feb 11, 2022
This was the template I was testing against ---
apiVersion: 'deploy.razee.io/v1alpha2'
kind: MustacheTemplate
metadata:
name: mergedconfig
namespace: default
labels:
app: ingress-kong
razee/watch-resource: "debug"
spec:
templateEngine: handlebars
envFrom:
- configMapRef:
name: four
namespace: default
- secretMapRef:
name: one
namespace: default
- genericMapRef:
apiVersion: v1
kind: ConfigMap
name: two
namespace: default
env:
- name: foobar
valueFrom:
configMapKeyRef:
name: two
namespace: default
key: sample
type: json
- name: missing
optional: true
valueFrom:
configMapKeyRef:
name: two
namespace: default
key: missing
type: number
- name: sample
overrideStrategy: merge
optional: true
valueFrom:
genericKeyRef:
namespace: default
apiVersion: v1
kind: ConfigMap
matchLabels:
app: core
key: sample
type: json
default: |
{}
- name: extra
overrideStrategy: merge
valueFrom:
secretKeyRef:
namespace: default
name: one
key: extra
strTemplates:
- |
apiVersion: v1
kind: List
items:
- apiVersion: v1
kind: ConfigMap
metadata:
name: merged
namespace: default
labels:
app: "merged"
razee/watch-resource: "debug"
data:
extra: "{{{extra}}}"
red: "{{{red}}}"
generic: "{{{foobar.test.generic}}}"
a: "{{{a}}}"
{{#each sample}}
{{#each this}}
{{{@key}}}: "{{{this}}}"
{{/each}}
{{/each}} |
esatterwhite
force-pushed
the
esatterwhite/env-label-selectors
branch
from
February 11, 2022 18:18
834e486
to
114d029
Compare
alewitt2
reviewed
Feb 11, 2022
alewitt2
reviewed
Feb 11, 2022
alewitt2
reviewed
Feb 11, 2022
esatterwhite
force-pushed
the
esatterwhite/env-label-selectors
branch
from
February 11, 2022 20:50
114d029
to
a6e8e0c
Compare
alewitt2
requested changes
Feb 15, 2022
esatterwhite
force-pushed
the
esatterwhite/env-label-selectors
branch
from
February 17, 2022 10:55
a6e8e0c
to
a5dbe82
Compare
alewitt2
reviewed
Feb 17, 2022
alewitt2
reviewed
Feb 17, 2022
esatterwhite
force-pushed
the
esatterwhite/env-label-selectors
branch
from
February 17, 2022 18:42
a5dbe82
to
d344be1
Compare
esatterwhite
force-pushed
the
esatterwhite/env-label-selectors
branch
3 times, most recently
from
February 18, 2022 15:24
9c5a9f4
to
f0d8fcd
Compare
alewitt2
requested changes
Feb 18, 2022
esatterwhite
force-pushed
the
esatterwhite/env-label-selectors
branch
from
February 18, 2022 16:10
f0d8fcd
to
eb08a2c
Compare
Allow `matchLabels` on key ref lookups. This is primarily to enable config map discovery when merging JSON keys. Allowing lable selectors means a single mtp doesn't have to add a key lookup for every configmap it wishes to source from. fixes: razee-io/MustacheTemplate#296
remove unused dependency that was failing audit scans
esatterwhite
force-pushed
the
esatterwhite/env-label-selectors
branch
from
February 18, 2022 16:14
eb08a2c
to
88cf0f8
Compare
alewitt2
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
matchLabels
on key ref lookups. This is primarily to enableconfig map discovery when merging JSON keys. Allowing lable selectors
means a single mtp doesn't have to add a key lookup for every configmap
it wishes to source from.
fixes: razee-io/MustacheTemplate#296