NET-4240 - Snapshots are failing on Windows #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense as on posix the reason for the fsync of the parent directory is to durably ensure that the rename is persisted to disk since the name-to-current-inode mapping is stored in the enclosing parent directory's inode/datablocks. IIRC Windows filesystems don't all behave like that (or possibly none do) and in some cases files know their own names, so it's unnecessary. |
rboyer
approved these changes
Jul 26, 2023
4 tasks
This was referenced Aug 2, 2023
Merged
Merged
wip-sync
pushed a commit
to NetBSD/pkgsrc-wip
that referenced
this pull request
Aug 11, 2023
SECURITY: * Update golang.org/x/net to v0.13.0 to address CVE-2023-3978. * Upgrade golang.org/x/net to address CVE-2023-29406 * Upgrade to use Go 1.20.6. This resolves CVE-2023-29406(net/http) for uses of the standard library. A separate change updates dependencies on golang.org/x/net to use 0.12.0. * Upgrade to use Go 1.20.7. This resolves vulnerability CVE-2023-29409(crypto/tls). FEATURES: * cli: consul members command uses -filter expression to filter members based on bexpr. * cli: consul operator raft list-peers command shows the number of commits each follower is trailing the leader by to aid in troubleshooting. * cli: consul watch command uses -filter expression to filter response from checks, services, nodes, and service. * reloadable config: Made enable_debug config reloadable and enable pprof command to work when config toggles to true * ui: consul version is displayed in nodes list with filtering and sorting based on versions IMPROVEMENTS: * Fix some typos in metrics docs * acl: added builtin ACL policy that provides global read-only access (builtin/global-read-only) * acl: allow for a single slash character in policy names * connect: Add capture group labels from Envoy cluster FQDNs to Envoy exported metric labels * connect: Improve transparent proxy support for virtual services and failovers. * connect: update supported envoy versions to 1.23.12, 1.24.10, 1.25.9, 1.26.4 * debug: change default setting of consul debug command. now default duration is 5ms and default log level is 'TRACE' * extensions: Improve validation and error feedback for property-override builtin Envoy extension * hcp: Add dynamic configuration support for the export of server metrics to HCP. * hcp: Removes requirement for HCP to provide a management token * http: GET API operator/usage endpoint now returns node count cli: consul operator usage command now returns node count * mesh: Expose remote jwks cluster configuration through jwt-provider config entry * mesh: Stop jwt providers referenced by intentions from being deleted. * ui: the topology view now properly displays services with mixed connect and non-connect instances. * xds: Explicitly enable WebSocket connection upgrades in HTTP connection manager BUG FIXES: * Fix a bug that wrongly trims domains when there is an overlap with DC name. * api-gateway: fix race condition in proxy config generation when Consul is notified of the bound-api-gateway config entry before it is notified of the api-gateway config entry. * api: Fix client deserialization errors by marking new Enterprise-only prepared query fields as omit empty * ca: Fixes a Vault CA provider bug where updating RootPKIPath but not IntermediatePKIPath would not renew leaf signing certificates * connect/ca: Fixes a bug preventing CA configuration updates in secondary datacenters * connect: (Enterprise only) Fix bug where intentions referencing sameness groups would not always apply to members properly. * connect: Fix incorrect protocol config merging for transparent proxy implicit upstreams. * connect: Removes the default health check from the consul connect envoy command when starting an API Gateway. This health check would always fail. * connect: fix a bug with Envoy potentially starting with incomplete configuration by not waiting enough for initial xDS configuration. * gateway: Fixes a bug where envoy would silently reject RSA keys that are smaller than 2048 bits, we now reject those earlier in the process when we validate the certificate. * http: fixed API endpoint PUT /acl/token/:AccessorID (update token), no longer requires AccessorID in the request body. Web UI can now update tokens. * mesh: (Enterprise Only) Require that jwt-provider config entries are created in the default namespace. * snapshot: fix access denied and handle is invalid when we call snapshot save on windows - skip sync() for folders in windows in rboyer/safeio#3 * xds: Prevent partial application of non-Required Envoy extensions in the case of failure.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR addresses the issue in NET-4240.
In windows we can not open directory - Windows official documentation.
Hence skipping the fsync for parent directory. Checked on windows node snapshot is creating successfully.