Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(usePopper): fix exported Modifier type #1013

Merged
merged 5 commits into from
Sep 16, 2022

Conversation

iz-podpolja
Copy link
Contributor

As per title, fixes: #1012

@kyletsang kyletsang changed the title Fixes #1012 fix(usePopper): fix exported Modifier type Sep 12, 2022
@kyletsang
Copy link
Member

Thanks for the PR. Could you run prettier on your code?

@iz-podpolja
Copy link
Contributor Author

Thanks for the PR. Could you run prettier on your code?

Sure - done.

@kyletsang
Copy link
Member

Thanks. Prettier looks good on the code, but we don't need those changes on the changelog

@kyletsang
Copy link
Member

There's also this error

Type 'undefined' does not satisfy the constraint 'Obj'.

@iz-podpolja
Copy link
Contributor Author

iz-podpolja commented Sep 13, 2022

There's also this error

Type 'undefined' does not satisfy the constraint 'Obj'.

Ok, excluded the changelog.md from prettier output and added a util to proxify undefined with Popper.Obj.
Tests, lint & tsc --noEmit are green for me.

@kyletsang kyletsang merged commit 96b3425 into react-bootstrap:master Sep 16, 2022
@kyletsang
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-overlays won't compile with typescript 4.7+
2 participants