Skip to content

Commit

Permalink
doctor : Modifying the version ranges to keep up to date with RN 0.72 (
Browse files Browse the repository at this point in the history
…#1858)

* Modifying the version to keep up to date

* Modifying the version to keep up to date
  • Loading branch information
arushikesarwani94 authored Mar 6, 2023
1 parent b7954c9 commit 08b140a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe('androidNDK', () => {
// To avoid having to provide fake versions for all the Android SDK tools
// @ts-ignore
environmentInfo.SDKs['Android SDK'] = {
'Android NDK': '18',
'Android NDK': '22',
};
const diagnostics = await androidNDK.getDiagnostics(environmentInfo);
expect(diagnostics.needsToBeFixed).toBe(true);
Expand All @@ -43,7 +43,7 @@ describe('androidNDK', () => {
// To avoid having to provide fake versions for all the Android SDK tools
// @ts-ignore
environmentInfo.SDKs['Android SDK'] = {
'Android NDK': '19',
'Android NDK': '23',
};
const diagnostics = await androidNDK.getDiagnostics(environmentInfo);
expect(diagnostics.needsToBeFixed).toBe(false);
Expand Down
4 changes: 2 additions & 2 deletions packages/cli-doctor/src/tools/versionRanges.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ export default {
RUBY: '>= 2.7.6',
JAVA: '>= 11',
// Android
ANDROID_SDK: '>= 31.x',
ANDROID_NDK: '>= 19.x',
ANDROID_SDK: '>= 33.x',
ANDROID_NDK: '>= 23.x',
// iOS
XCODE: '>= 12.x',
COCOAPODS: '>= 1.10.0',
Expand Down

0 comments on commit 08b140a

Please sign in to comment.