Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new NativeEventEmitter() was called with a non-null argument console warning #460

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reynaldichernando
Copy link

Add addListener and removeListeners method to stop console warning about:

WARN new NativeEventEmitter() was called with a non-null argument without the required addListener method.
WARN new NativeEventEmitter() was called with a non-null argument without the required removeListeners method.

Issue #455

reference

@rzfzr
Copy link

rzfzr commented Nov 27, 2023

Is this a breaking change or just a warning? I'm trying to figure out why voice is not working.

Edit for reference: not a breaking change that I could see, voice still worked despite the warning

Copy link

@angusryer angusryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone with write permissions approve this? (eg. @carlmagumpara I think, among several others)

Adding these methods resolves the related RN warnings. This is not a breaking change since it does not implement any functional code changes or modify dependencies.

@angusryer
Copy link

NOTE: Anyone can review this PR, but in order for it to be merged automatically, we need the author or a contributor to review it.

@cetorres
Copy link

Please merge this changes.
Thank you.

@abasiri
Copy link

abasiri commented Jul 22, 2024

Verified that this fixes the issue for me. Would be good if it gets merged.
cc: @wenkesj @safaiyeh Thank you.

@AshwinTayson
Copy link

Can someone merge this? Or is this not maintained anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.