fix: fix android header title font weight #7720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Expo app for the example from this branch is ready! |
vonovak
force-pushed
the
@vonovak/fix-header-font-weight
branch
from
d6a1c79
to
3ef4f2b
Compare
|
The Expo app for the example from this branch is ready! |
the previously used fort weight of 500 would effectively be converted to `fontWeight: bold` because of facebook/react-native#25341 this fixes the title appearance to look as customary Update HeaderTitle.tsx
vonovak
force-pushed
the
@vonovak/fix-header-font-weight
branch
from
3ef4f2b
to
03b1161
Compare
Codecov Report
@@ Coverage Diff @@
## master #7720 +/- ##
=======================================
Coverage 90.56% 90.56%
=======================================
Files 40 40
Lines 1060 1060
Branches 276 281 +5
=======================================
Hits 960 960
Misses 86 86
Partials 14 14Continue to review full report at Codecov.
|
|
The Expo app for the example from this branch is ready! |
joshuapinter
pushed a commit
to cntral/react-navigation
that referenced
this pull request
Sep 29, 2021
the previously used fort weight of 500 would effectively be converted to `fontWeight: bold` because of facebook/react-native#25341 this fixes the title appearance to look as customary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previously used fort weight of 500 would effectively be converted to
fontWeight: bold. Because of facebook/react-native#25341 that does not happen as of 0.61 - fontWeight 500 for roboto actually is the same as 400 in latest RN. Because of that the title font doesn't look right (to me at least 😄 ) - it certainly looks different than before.this fixes the title appearance to look as customary (it's thicker than now, but not as thick as it used to be).
images: old behavior, master, my branch