fixes #318 partially #483
fixes #318 partially #483
Conversation
| innerCache.AddOrUpdate(new DeviceMetaData("Device1")); | ||
| innerCache.AddOrUpdate(new DeviceMetaData("Device2")); | ||
| innerCache.AddOrUpdate(new DeviceMetaData("Device3")); | ||
| innerCache.AddOrUpdate(new DeviceMetaData(1,"Device1")); |
There was a problem hiding this comment.
You will get syntax issues with these, you need a space after the 1, etc.
There was a problem hiding this comment.
as far as I see not in the test project...there's no StyleCop there
or am I missing something?
There was a problem hiding this comment.
There should be stylecop throughout the entire application. The test project is just a cut down version, eg doesn't require comments etc.
There was a problem hiding this comment.
I will do a PR with the editorconfig tomorrow to make it more consistent, so if your stuff gets merged in I'll handle the style fixes.
@RolandPheasant usually likes to review these ones personally.
|
Hi, just popped in to say I have not forgotten about this PR. I should be able to take a detailed look soon. |
|
This looks good to me and I see no reason not to merge it. It is possible that it may break some code out there but I will not lose sleep over it as the joins are obscure and not used by many people + this is a logical fix. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
for #318 fixes the RightJoin.
previous tests passed, but I modified them a bit and added some new tests.
Beware that this might be a breaking change for consumers because of the change from
TLeftKeytoTRightKey