Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: use sonar cloud code coveage #764

Merged
merged 17 commits into from
Nov 24, 2023
Merged

Conversation

glennawatson
Copy link
Member

Trying dotcover from jetbrains as the tool that collects the coverage information.

Using sonar cloud to store the coverage information.

@reactivemarbles reactivemarbles deleted a comment from codecov bot Nov 23, 2023
@reactivemarbles reactivemarbles deleted a comment from codecov bot Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 425 lines in your changes are missing coverage. Please review.

Comparison is base (53d5f6d) 64.74% compared to head (5ade7c4) 65.80%.
Report is 8 commits behind head on main.

❗ Current head 5ade7c4 differs from pull request most recent head 70ae6db. Consider uploading reports for the commit 70ae6db to get more accurate results

Files Patch % Lines
src/DynamicData/Cache/ObservableCacheEx.cs 53.48% 19 Missing and 1 partial ⚠️
src/DynamicData/List/ObservableListEx.cs 67.79% 16 Missing and 3 partials ⚠️
src/DynamicData/List/Internal/Transformer.cs 52.00% 9 Missing and 3 partials ⚠️
src/DynamicData/Aggregation/AvgEx.cs 73.68% 10 Missing ⚠️
src/DynamicData/Aggregation/SumEx.cs 74.35% 10 Missing ⚠️
src/DynamicData/ObservableChangeSet.cs 58.33% 10 Missing ⚠️
src/DynamicData/Platforms/net45/ParallelEx.cs 25.00% 7 Missing and 2 partials ⚠️
src/DynamicData/Aggregation/StdDevEx.cs 76.66% 5 Missing and 2 partials ⚠️
src/DynamicData/List/Internal/GroupOnProperty.cs 0.00% 7 Missing ⚠️
src/DynamicData/Aggregation/CountEx.cs 25.00% 6 Missing ⚠️
... and 127 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
+ Coverage   64.74%   65.80%   +1.06%     
==========================================
  Files         226      228       +2     
  Lines       11459    11181     -278     
  Branches     2334     2307      -27     
==========================================
- Hits         7419     7358      -61     
+ Misses       3083     2884     -199     
+ Partials      957      939      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glennawatson glennawatson marked this pull request as draft November 24, 2023 02:58
@glennawatson
Copy link
Member Author

Don't merge yet, it's not processing the code coverage info yet.

Copy link

sonarcloud bot commented Nov 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@glennawatson glennawatson marked this pull request as ready for review November 24, 2023 03:37
@glennawatson glennawatson merged commit 33bbe3e into main Nov 24, 2023
4 checks passed
@glennawatson glennawatson deleted the glennawatson-patch-1 branch November 24, 2023 03:37
Copy link

github-actions bot commented Dec 9, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant