Fix cache in RestService for generated type #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennawatson
approved these changes
Apr 12, 2023
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
BugFix
What is the current behavior?
There is a dictionary for caching the type for generated interfaces. However, the type is currently created anew each time and thus hijacks the cache!
What is the new behavior?
The type is generated only once.
What might this PR break?
nothing
Please check if the PR fulfills these requirements
Other information:
The old solution called the method "GetGeneratedType" each time and thus generated the type again each time. Even if the type was already registered in the dictionary.
The new solution only passes a method pointer (delegate) and only calls the method if the type does not yet exist in the dictionary.