-
-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Error property when throwing exception #1448
Conversation
I dont see any tests in this PR? |
Is adding a new test class to Refit.Tests enough? Thank you @304NotModified |
That's a bit hard to decide without any test code. But I think only an unit tests is needed, not a integration test / service test or something like that. (See https://martinfowler.com/articles/practical-test-pyramid.html)
|
Thank you for the clarification @304NotModified, I have added a Unit test for this change. |
Thanks for the tests! Added some comments to make them a bit better :) |
Done :) Let me know if now is OK! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This will also fix #1465 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
See #1376
Please check if the PR fulfills these requirements
Other information:
Fixes #1376