Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1684 Tweak Dependencies #1693

Merged

Conversation

thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Apr 30, 2024

What kind of change does this PR introduce?
update

What is the current behavior?
Packages are the same for all TFM's

What is the new behavior?
Less dependencies are included for net 6+ due to them being available as part of the framework

What might this PR break?
n/a

Other information:
closes #1684

@thompson-tomo thompson-tomo force-pushed the chore/#1684_TweakDependencies branch from 70037d8 to 3727a0d Compare May 8, 2024 15:50
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.73%. Comparing base (6ebeda5) to head (3727a0d).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1693   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files          33       33           
  Lines        2348     2348           
  Branches      294      293    -1     
=======================================
  Hits         2060     2060           
  Misses        208      208           
  Partials       80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman ChrisPulman merged commit 76ed19c into reactiveui:main May 9, 2024
3 checks passed
@thompson-tomo thompson-tomo deleted the chore/#1684_TweakDependencies branch May 9, 2024 00:57
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leverage framework to provide dependencies
2 participants