Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor, invert ifs, use optimal methods #1713

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

TimothyMakkison
Copy link
Contributor

@TimothyMakkison TimothyMakkison commented Jun 10, 2024

I can't guarantee that I've caught everything. Future PR needs to rerun csharpier

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 83.63636% with 9 lines in your changes missing coverage. Please review.

Project coverage is 86.50%. Comparing base (6ebeda5) to head (8365e59).
Report is 34 commits behind head on main.

Files Patch % Lines
Refit/RequestBuilderImplementation.cs 83.63% 5 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1713      +/-   ##
==========================================
- Coverage   87.73%   86.50%   -1.23%     
==========================================
  Files          33       34       +1     
  Lines        2348     2068     -280     
  Branches      294      295       +1     
==========================================
- Hits         2060     1789     -271     
+ Misses        208      201       -7     
+ Partials       80       78       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman ChrisPulman merged commit 51ef445 into reactiveui:main Jun 10, 2024
1 of 3 checks passed
@ChrisPulman
Copy link
Member

Thank you @TimothyMakkison

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants