Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added source generator benchmarks #1798

Merged
merged 3 commits into from
Sep 1, 2024

Conversation

TimothyMakkison
Copy link
Contributor

@TimothyMakkison TimothyMakkison commented Aug 30, 2024

Added benchmarks for source generation.

Assuming these benchmarks are valid, the results show a very small benefit from caching.

Benchmarks

Method Mean Error StdDev Gen0 Gen1 Allocated
Compile 225.9 us 3.34 us 2.96 us 13.1836 2.9297 124.09 KB
Cached 196.7 us 3.37 us 2.99 us 13.1836 2.9297 122.19 KB
Method Mean Error StdDev Median Gen0 Gen1 Allocated
Compile 225.0 us 4.42 us 9.22 us 221.2 us 13.1836 2.9297 124.09 KB
Cached 197.6 us 2.77 us 2.59 us 197.0 us 13.1836 2.9297 122.18 KB
Method Mean Error StdDev Gen0 Gen1 Allocated
Compile 228.9 us 4.55 us 6.67 us 13.1836 2.9297 124.09 KB
Cached 197.5 us 2.14 us 2.00 us 13.1836 2.9297 122.18 KB

#1791

@TimothyMakkison TimothyMakkison marked this pull request as draft August 30, 2024 22:26
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.66%. Comparing base (6ebeda5) to head (d6a4e2a).
Report is 79 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1798      +/-   ##
==========================================
- Coverage   87.73%   83.66%   -4.08%     
==========================================
  Files          33       36       +3     
  Lines        2348     2442      +94     
  Branches      294      345      +51     
==========================================
- Hits         2060     2043      -17     
- Misses        208      316     +108     
- Partials       80       83       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimothyMakkison
Copy link
Contributor Author

Do you want me to rebase this?

@ChrisPulman ChrisPulman enabled auto-merge (squash) September 1, 2024 16:37
@ChrisPulman ChrisPulman merged commit f77f0f3 into reactiveui:main Sep 1, 2024
1 check passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants