Added support for ranges between element and text nodes when generating range CFIs. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vilmosioo what do you think about adding a couple of unit tests to cover the new functionality? This library is fairly well covered by previous owner and it would make sense for the long term. |
|
I completely agree! |
|
Count my vote in for unit tests |
Added support for ranges between element and text nodes when generating range CFIs.
|
Added unit tests to cover all cases. |
|
Hello @vilmosioo (Vilmos Ioo / Blinkbox Books), |
|
Will do! |
|
Thanks @vilmosioo much appreciated! Moved here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10