Migrates the build from Rake to grunt #16
Conversation
| // start these browsers | ||
| // available browser launchers: https://npmjs.org/browse/keyword/karma-launcher | ||
| //browsers: ['Chrome'], | ||
| browsers: ['Chrome'], |
There was a problem hiding this comment.
I would recommend switching this to PhantomJS instead as not all build machines have Chrome installed (Travis comes to mind).
Edit: just noticed the karma file for travis... in that case, why bother with the two of them?
There was a problem hiding this comment.
@vilmosioo Thanks for the recommendation. For mysterious reasons, some tests consistently fail only on PhantomJS. Therefore, as a team we decided not to use PhantomJS to run the tests.
The travis CI build uses https://saucelabs.com to run the unit tests in a browser since we don't want to use PhantomJS. We want to limit the use of sauce to our CI builds since we are on a free plan and have limited access. Therefore, there is a local config for running the build locally using your installed version of Chrome.
There was a problem hiding this comment.
" For mysterious reasons, some tests consistently fail only on PhantomJS. Therefore, as a team we decided not to use PhantomJS to run the tests." Oddly enough, that sounds very familiar to me.
The decision makes sense. Just a quick suggestion though. Have you considered using only one karma file and override some settings from Gruntfile? It would avoid redundancy.
There was a problem hiding this comment.
Yes, the browser config is less straightforward for using sauce and I didn't want to spend a lot of time trying to make it work. If you're interested in doing this. I would be happy to accept a pull request (after this one is merged)
There was a problem hiding this comment.
As a big fan of grunt, would be happy to do it!
|
I would like to see this 👍 |
|
Thanks for putting this together, Ryan. |
Migrates the build from Rake to grunt
Note: I originally set out to encrypt our credentials for Sauce in this repo and the viewer repo but it was causing me problems so I dropped it. I don't think anyone would be too motivated to use the credentials since we only have the free plan available to anyone. If it becomes a problem later we can invalidate the access key and look at encrypting it then.