Template optimizations on version listing #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along with a model prefetch change in the view, this reduces the number of queries by 90 queries, from 132 to 42. This: - Uses prefetchs build for `latest_build` to avoid multiple lookups on `Version.build` - Retains usage of a prefetched `project` on Version - Swaps some permission check logic to only perform additional user queries on private versions - Passes a project object into the build chip to avoid a lookup on `Build.project.*` - Refs #61 - Fixes #463
agjohnson
added a commit
to readthedocs/readthedocs.org
that referenced
this pull request
Sep 23, 2024
This optimizes the version listing view and removes redundant queries. - Requires readthedocs/ext-theme#493 - Fixes readthedocs/ext-theme#463
This was referenced Sep 23, 2024
ericholscher
approved these changes
Sep 24, 2024
humitos
approved these changes
Sep 25, 2024
humitos
pushed a commit
to readthedocs/readthedocs.org
that referenced
this pull request
Sep 25, 2024
This optimizes the version listing view and removes redundant queries. - Requires readthedocs/ext-theme#493 - Fixes readthedocs/ext-theme#463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with a model prefetch change in the view, this reduces the number of
queries by 90 queries, from 132 to 42. This:
last_build/latest_buildto avoid multiple lookups onVersion.buildprojecton Version to reduce extra project queriesBuild.project.*