-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an initial resync_versions API to v3 #11484
Conversation
This will be used in the frontend, but also available as an API. Mostly curious if this is a good approach, and I can get some tests together for it. Refs #6090
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is fine. However, I'm proposing to use PATCH
method over a URL we already have. This will simplify the PR and keep our endpoints semantically consistent across them.
Co-authored-by: Santos Gallegos <stsewd@proton.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, we should document this new endpoint.
docs/user/api/v3.rst
Outdated
:statuscode 204: Updated successfully | ||
:statuscode 204: Task created successfully | ||
:statuscode 400: Bad request, task not created |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be below the next section...
Co-authored-by: Santos Gallegos <stsewd@proton.me>
This will be used in the frontend,
but also available as an API.
Mostly curious if this is a good approach,
and I can get some tests together for it.
Looks like:
Refs #6090