Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore an alternative way of explaining states #11512

Merged
merged 8 commits into from
Aug 8, 2024
Merged

Conversation

plaindocs
Copy link
Contributor

@plaindocs plaindocs commented Aug 5, 2024

Some quick noodling on #11508 -- this makes more sense to me, but I'm happy to have another bash.

Is there a canonical link for allocating permissions? Or is that all tied in up SSO?


📚 Documentation previews 📚

@plaindocs plaindocs requested a review from a team as a code owner August 5, 2024 13:04
The "remove edit buttons" file was deleted in #11468
@plaindocs
Copy link
Contributor Author

Hmmm, actually we talk about privacy levels and document states, and this change obfuscates that a little.

@ericholscher
Copy link
Member

ericholscher commented Aug 5, 2024

Yea, it's a bit confusing, but I think this PR is definitely a step in the right direction. "Not hidden" is a bit of an odd state, but useful to explicitly note.

I feel like the "How we envision this working" is also weird and something I want to update, and we should probably note a couple different workflows that are enabled, and suggestions for when they are the best option.

I can try to take a swing at the "How we envision this working" section if it makes sense in this PR, or should I open another to not mix things up?

docs/user/versions.rst Outdated Show resolved Hide resolved
@plaindocs
Copy link
Contributor Author

@ericholscher I'm just pushing up some changes to that section, but feel free to revert and propose edits in this PR, or build from it.

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels way better than what we had before 👍

docs/user/versions.rst Outdated Show resolved Hide resolved
docs/user/versions.rst Outdated Show resolved Hide resolved
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
docs/user/versions.rst Outdated Show resolved Hide resolved
@plaindocs plaindocs merged commit 5591e5f into main Aug 8, 2024
8 checks passed
@plaindocs plaindocs deleted the sam/versions branch August 8, 2024 08:35
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement! 💯 . I left a few comments that we can consider.

@plaindocs plaindocs mentioned this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants