-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Conda as a build environment #1849
Conversation
eb41d36
to
36db0d0
Compare
This adds a new abstractions to the builds, along with the Environment (Machine, Docker, etc). This is the Python Environment we want to build in. This allows us to support Conda & Virtualenv as different backends to the same API.
This allows YAML and project config to co-exist, until we fully move to YAML only configs.
4c2b74a
to
aaffe6e
Compare
What is conda environment file? Is the format somewhere documented? Is it possible to be conda-free and use only standard Python tools? |
must be in the root directory of your project. | ||
|
||
.. warning:: This feature is in a beta state. | ||
Please file an Issue if you find anything wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spurious proper capitalization on Issue
, might be good to link issue tracker or docs on submitting issue if we have that.
@techtonik we're starting to implement this with http://github.com/rtfd/readthedocs-build, there's more loose info there. |
@agjohnson awesome, thanks for the pointer. |
Add support for Conda as a build environment
'--name', | ||
self.version.slug, | ||
'python={python_version}'.format(python_version=self.config.python_version), | ||
environment={'CONDA_ENVS_PATH': conda_env_path} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear, this environment is being used when shelling out? Is it possible to add or change arguments here? Is CONDA_ENVS_PATH
used internally somehow or is this intended for use with conda
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an argument to conda: http://conda.pydata.org/docs/install/central.html#specify-environment-directories-envs-dirs -- it tells conda where to install an environment, so that we can specify which env to run commands against.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok. Thanks for clarifying. Have never actually overridden this one.
So, are the environments somewhere different from the base install?
In any event, having this variable will probably make this change even easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, we install a custom environment for each build, so this is the path to that environment, which is named after the version we're building.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I guess I am still unclear on how these environments related to the builders or are they?
This is a work in progress that adds support for specifying a conda Environment File for your documentation build.
It still needs the following: