Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Conda as a build environment #1849

Merged
merged 31 commits into from
Dec 29, 2015
Merged

Add support for Conda as a build environment #1849

merged 31 commits into from
Dec 29, 2015

Conversation

ericholscher
Copy link
Member

This is a work in progress that adds support for specifying a conda Environment File for your documentation build.

It still needs the following:

  • Tests
  • More specific documentation (especially around limitations and usage)

@ericholscher ericholscher added the PR: work in progress Pull request is not ready for full review label Dec 7, 2015
@ericholscher ericholscher added PR: ready for review and removed PR: work in progress Pull request is not ready for full review labels Dec 17, 2015
@techtonik
Copy link
Contributor

What is conda environment file? Is the format somewhere documented? Is it possible to be conda-free and use only standard Python tools?

must be in the root directory of your project.

.. warning:: This feature is in a beta state.
Please file an Issue if you find anything wrong.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spurious proper capitalization on Issue, might be good to link issue tracker or docs on submitting issue if we have that.

@agjohnson
Copy link
Contributor

@techtonik we're starting to implement this with http://github.com/rtfd/readthedocs-build, there's more loose info there.

@techtonik
Copy link
Contributor

@agjohnson awesome, thanks for the pointer.

agjohnson added a commit that referenced this pull request Dec 29, 2015
Add support for Conda as a build environment
@agjohnson agjohnson merged commit 7189419 into master Dec 29, 2015
@shoyer shoyer mentioned this pull request Jan 12, 2016
8 tasks
'--name',
self.version.slug,
'python={python_version}'.format(python_version=self.config.python_version),
environment={'CONDA_ENVS_PATH': conda_env_path}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, this environment is being used when shelling out? Is it possible to add or change arguments here? Is CONDA_ENVS_PATH used internally somehow or is this intended for use with conda?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an argument to conda: http://conda.pydata.org/docs/install/central.html#specify-environment-directories-envs-dirs -- it tells conda where to install an environment, so that we can specify which env to run commands against.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok. Thanks for clarifying. Have never actually overridden this one.

So, are the environments somewhere different from the base install?

In any event, having this variable will probably make this change even easier.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, we install a custom environment for each build, so this is the path to that environment, which is named after the version we're building.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I guess I am still unclear on how these environments related to the builders or are they?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants