This repository has been archived by the owner on Mar 25, 2022. It is now read-only.
Bugfix: External links to 'supported' files lose their file extension #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 4, 2019 16:10
Fixes the following TODO: # TODO this should probably only remove the extension for local paths, # i.e. not uri's starting with http or other external prefix. Concrete example: Links to external files with supported extensions (e.g. .md) were broken, e.g. external links to Github README.md files.
Gabriella439
added a commit
to dhall-lang/dhall-lang
that referenced
this pull request
Feb 23, 2020
Fixes #920 The problem is due to a bug in `recommonmark` which is fixed by this pull request: readthedocs/recommonmark#181 ... and this change applies the changes in that pull request as a patch to `recommonmark`. This includes an upgrade to `nixpkgs` because the version we were using had an older version of `recommonmark` where the patch didn't cleanly apply.
Gabriella439
added a commit
to dhall-lang/dhall-lang
that referenced
this pull request
Feb 23, 2020
Fixes #920 The problem is due to a bug in `recommonmark` which is fixed by this pull request: readthedocs/recommonmark#181 ... and this change applies the changes in that pull request as a patch to `recommonmark`. This includes an upgrade to `nixpkgs` because the version we were using had an older version of `recommonmark` where the patch didn't cleanly apply.
Gabriella439
added a commit
to dhall-lang/dhall-lang
that referenced
this pull request
Feb 24, 2020
Fixes #920 The problem is due to a bug in `recommonmark` which is fixed by this pull request: readthedocs/recommonmark#181 ... and this change applies the changes in that pull request as a patch to `recommonmark`. This includes an upgrade to `nixpkgs` because the version we were using had an older version of `recommonmark` where the patch didn't cleanly apply.
|
@ericholscher any chance this one can be merged? |
|
Quick bump here to ask when this can be merged? :) |
|
Would it be possible to make a new release with this commit? Quite a few dependants are broken because of it :) |
|
Gentle nudge here - we'd love a new release. |
|
Sorry, I will make sure this happens this week. |
|
No apologies needed, thank you, Eric!
…On Mon, Dec 14, 2020 at 11:08 AM Eric Holscher ***@***.***> wrote:
Sorry, I will make sure this happens this week.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#181 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB5I42KIEI3CIIOVTVU4W3SUYZ6HANCNFSM4JIVJAWQ>
.
|
|
A new version has now been released with this 👍 |
|
Thank you!
…On Thu, Dec 17, 2020, 2:26 PM Eric Holscher ***@***.***> wrote:
A new version has now been released with this 👍
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#181 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB5I4ZLVRJRFOTLA3LYQK3SVJLMPANCNFSM4JIVJAWQ>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR fixes the erroneous handling of external links to 'supported' files.
Until now, the extension of every supported type has been stripped.
Adding an additional check ("if not scheme_known") was sufficient to avoid doing this for external links.
Example:
A link to http://example.com/README.md will point to http://example.com/README without this fix, since 'md' is a supported type.
Example 2:
Simply linking to this project's README file is impossible at the moment:
https://github.com/readthedocs/recommonmark/blob/master/README.md becomes https://github.com/readthedocs/recommonmark/blob/master/README, which of course doesn't exist.