Skip to content
This repository has been archived by the owner on Mar 25, 2022. It is now read-only.

Set rawsource value of each node to use as translation source for Sphinx i18n feature #187

Closed
wants to merge 1 commit into from

Conversation

jpmckinney
Copy link

This fixes a regression. @shimizukawa originally fixed this in fc18fa7

This depends on the following bug being fixed in commonmark: readthedocs/commonmark.py#225

Note that Markdown can't be translated properly without these two bug fixes.

noritada added a commit to noritada/recommonmark that referenced this pull request Sep 6, 2020
noritada added a commit to noritada/recommonmark that referenced this pull request Sep 6, 2020
noritada added a commit to noritada/recommonmark that referenced this pull request Sep 6, 2020
@noritada
Copy link

noritada commented Sep 6, 2020

As I wrote in #208 , this PR will close #163 and also close #169. I am also troubled by the i18n issue and this PR (plus related fix of commonmark) works well for me. I hope this PR will be merged.

@jpmckinney
Copy link
Author

@astrojuanlu
Copy link
Contributor

I use https://myst-parser.readthedocs.io/en/latest/ and https://markdown-it-py.readthedocs.io/en/latest/ instead now.

These are more maintained these days, and that's one of the reasons why we proposed to sunset recommonmark #221 please head over to that conversation, because unfortunately it's unlikely that this issue is solved.

@jpmckinney
Copy link
Author

I am abandoning the PR given #221.

@jpmckinney jpmckinney closed this Apr 22, 2021
@jpmckinney jpmckinney deleted the i18n-rawsource branch April 22, 2021 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants