Add bindings for useTransition hook #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds bindings for the useTransition hook for React (experimental) - useTransition - useTransitionWithConfig // calls useTransition with the specified config @rickyvetter don't land until it's released in React
rickyvetter
suggested changes
Mar 3, 2020
There was a problem hiding this comment.
Thanks @kiangtengl! Will add once the React API is finalized.
| @@ -390,3 +390,10 @@ external useImperativeHandle7: | |||
|
|
|||
| [@bs.set] | |||
| external setDisplayName: (component('props), string) => unit = "displayName"; | |||
|
|
|||
| [@bs.deriving abstract] | |||
There was a problem hiding this comment.
Note here for me mostly - drop this if we end up bumping BS min version to record as obj support.
|
Hey @kiangtengl If you don't mind, can you please update these changes and we can merge this in, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds bindings for the useTransition hook for React (experimental)
@rickyvetter don't land until it's released in React